fix: pin ansible-lint to 4.1.0 (has default_rulesdir in __init__)

Reviewed-on: #5

.gitea/workflows/docker-build.yaml

@@ -2,45 +2,69 @@ name: Docker Build and Push
 
 on:
   pull_request:
-    branches: [master]
   push:
-    branches: [master]
   schedule:
-    - cron: '0 0 * * *'
+    - cron: '30 3 * * 3'
 
 jobs:
-  build:
+  lint:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10
+      - name: Hadolint
+        uses: hadolint/hadolint-action@54c9adbab1582c2ef04b2016b760714a4bfde3cf
 
-      - name: Set up Docker Buildx
+  build:
-        uses: docker/setup-buildx-action@v4
+    runs-on: ubuntu-latest
+    needs: lint
+    steps:
+      - name: Checkout
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10
+      - name: Build image
+        run: docker build -t ci-image:${{ github.sha }} .
+      - name: Save image
+        run: docker save ci-image:${{ github.sha }} > image.tar
+      - name: Upload artifact
+        uses: ChristopherHX/gitea-upload-artifact@62ac910c5d3dfa85c7cb2df15afe2e342b2407c2
+        with:
+          name: docker-image
+          path: image.tar
 
+  test:
+    runs-on: ubuntu-latest
+    needs: build
+    steps:
+      - name: Checkout
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10
+      - name: Download artifact
+        uses: ChristopherHX/gitea-download-artifact@75635f32b4c1c41c4b3d64e8f85210112ed4c9c7
+        with:
+          name: docker-image
+      - name: Load image
+        run: docker load < image.tar
+      - name: Run tests
+        run: bash tests/test.sh ci-image:${{ github.sha }}
+
+  push:
+    runs-on: ubuntu-latest
+    if: github.event_name != 'pull_request'
+    needs: test
+    steps:
+      - name: Checkout
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10
+      - name: Download artifact
+        uses: ChristopherHX/gitea-download-artifact@75635f32b4c1c41c4b3d64e8f85210112ed4c9c7
+        with:
+          name: docker-image
+      - name: Load image
+        run: docker load < image.tar
       - name: Login to Docker Hub
-        if: github.event_name != 'pull_request'
+        uses: docker/login-action@650006c6eb7dba73a995cc03b0b2d7f5ca915bee
-        uses: docker/login-action@v4
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_TOKEN }}
-
+      - name: Tag and push
-      - name: Docker metadata
+        run: |
-        id: meta
+          docker tag ci-image:${{ github.sha }} jcabillot/ansible-review:latest
-        uses: docker/metadata-action@v6
+          docker push jcabillot/ansible-review:latest
-        with:
-          images: jcabillot/ansible-review
-          tags: |
-            #type=ref,event=branch
-            #type=ref,event=pr
-            #type=sha
-            type=raw,value=latest,enable=${{ github.ref == 'refs/heads/master' }}
-
-      - name: Build and push
-        uses: docker/build-push-action@v7
-        with:
-          context: .
-          push: ${{ github.event_name != 'pull_request' }}
-          tags: ${{ steps.meta.outputs.tags }}
-          labels: ${{ steps.meta.outputs.labels }}
-          pull: true

Dockerfile

@@ -1,30 +1,32 @@
-FROM "python:3.7-alpine"
+FROM python:3.7-alpine
 
 ARG BUILD_DATE
 ARG VCS_REF
 ARG VERSION
+ARG ANSIBLE_REVIEW_VERSION=0.13.9
 
+# hadolint ignore=DL3018
 RUN apk --no-cache add --virtual build-dependencies \
-        build-base libffi-dev libressl-dev && \
+        build-base libffi-dev libressl-dev
-    pip install --no-cache-dir ansible-review && \
+
+# hadolint ignore=DL3013
+RUN pip install --no-cache-dir ansible-review==0.13.9 'ansible-lint==4.1.0' && \
     apk del build-dependencies
 
-LABEL "maintainer"="dockerimages@cabillot.eu" \
+LABEL maintainer="dockerimages@cabillot.eu" \
-      "org.label-schema.name"="ansible-review" \
+      org.label-schema.name="ansible-review" \
-      "org.label-schema.base-image.name"="docker.io/library/python" \
+      org.label-schema.base-image.name="docker.io/library/python" \
-      "org.label-schema.base-image.version"="3.7-alpine" \
+      org.label-schema.base-image.version="3.7-alpine" \
-      "org.label-schema.description"="Ansible-review in a container" \
+      org.label-schema.description="Ansible-review in a container" \
-      "org.label-schema.url"="https://github.com/willthames/ansible-review" \
+      org.label-schema.url="https://github.com/willthames/ansible-review" \
-      "org.label-schema.vcs-url"="https://gitlab.cabillot.eu/jcabillot/ansible-review/" \
+      org.label-schema.vcs-url="https://gitlab.cabillot.eu/jcabillot/ansible-review/" \
-      "org.label-schema.vendor"="Julien Cabillot" \
+      org.label-schema.vendor="Julien Cabillot" \
-      "org.label-schema.schema-version"="1.0" \
+      org.label-schema.schema-version="1.0" \
-      "org.label-schema.applications.ansiblelint.version"="latest" \
+      org.label-schema.applications.ansiblelint.version="latest" \
-      "org.label-schema.vcs-ref"="$VCS_REF" \
+      org.label-schema.vcs-ref="$VCS_REF" \
-      "org.label-schema.version"="$VERSION" \
+      org.label-schema.version="$VERSION" \
-      "org.label-schema.build-date"="$BUILD_DATE" \
+      org.label-schema.build-date="$BUILD_DATE" \
-      "org.label-schema.usage"="docker run --rm -v $(pwd):/data registry.cabillot.eu/jcabillot/ansible-review -p ."
+      org.label-schema.usage="docker run --rm -v $(pwd):/data registry.cabillot.eu/jcabillot/ansible-review -p ."
-# TODO: fix this last line
 
 ENTRYPOINT [ "/usr/local/bin/ansible-review" ]
 CMD [ "--help" ]
-# TOREAD: https://gist.github.com/paul-butcher/7bab39b85abc9c7334df02004cba2eb3

renovate.json

@@ -0,0 +1,15 @@
+{
+  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
+  "gitlabci": {
+    "enabled": false
+  },
+  "regexManagers": [
+    {
+      "description": "Track ansible-review pip version from ARG in Dockerfile",
+      "fileMatch": ["^Dockerfile$"],
+      "matchStrings": ["ARG ANSIBLE_REVIEW_VERSION=(?<currentValue>[\\d.]+)\\n"],
+      "depNameTemplate": "ansible-review",
+      "datasourceTemplate": "pypi"
+    }
+  ]
+}

tests/test.sh

@@ -0,0 +1,8 @@
+#!/bin/bash
+set -euo pipefail
+IMAGE="${1:-}"
+if [ -z "$IMAGE" ]; then
+  echo "Usage: $0 <image>"
+  exit 1
+fi
+docker run --rm "$IMAGE" --version