perso/syncthing-arm
Archived
4
0
Fork 0
Code Issues 1 Pull Requests 10 Actions Releases Wiki Activity
4,731 Commits 12 Branches 0 Tags
a2f51c85c2748fa392193b31c2734b92198ed7d0
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Simon Frei a2f51c85c2 lib/osutil: Add test for IsDeleted (ref #4925) (#4936) 2018-05-10 21:39:33 +02:00
Simon Frei 00f4900ba7 build: Increase test timeout to 2min (#4937) 2018-05-10 21:38:49 +02:00
Simon Frei a94aceb22f lib/model: Don't create folder root when paused (fixes #4903) (#4904) 2018-05-05 10:30:39 +02:00
Simon Frei 53dc346583 lib/model: Fix test function for introducer (#4898) 2018-05-01 22:56:20 +01:00
Simon Frei a548014755 lib/db, lib/model: Add sequence->deviceKey to db for sending indexes (#4906) 
Instead of walking and unmarshalling the entire db and sorting the resulting
file infos by sequence, add store device keys by sequence number in the
database. Thus only the required file infos need be unmarshalled and are already
sorted by index.
 2018-05-01 23:39:15 +02:00
Simon Frei f6458d1b8f lib/config, lib/model: Include paused folders in cluster config (fixes #4897) 2018-04-22 17:01:52 +01:00
Simon Frei a1b5a3d5c0 vendor: Update github.com/syncthing/notify (fixes #4885) (#4894) 2018-04-21 13:42:08 +02:00
Simon Frei 3d02fcd473 vendor: Update github.com/syncthing/notify (fixes #4885) (#4894) 2018-04-20 17:01:03 +02:00
Simon Frei 1f70f7e37c lib/osutil: Fix TraversesSymlink with symlinked fs root on windows (fixes #4875) (#4886) 2018-04-18 07:28:35 +02:00
Simon Frei eca076cf7d lib/osutil: Fix TraversesSymlink with symlinked fs root on windows (fixes #4875) (#4886) 2018-04-17 22:53:06 +02:00
Simon Frei 17e3608865 lib/fs: Fix watcher panic due to casing on windows (fixes #4877) (#4878) 2018-04-16 20:10:11 +02:00
Simon Frei 01aef75c96 lib/fs: Fix watcher panic due to casing on windows (fixes #4877) (#4878) 2018-04-16 20:07:00 +02:00
Simon Frei 4072ae4d05 lib/model: Prevent warning on request in paused folder (fixes #4870) 2018-04-09 20:55:52 +01:00
Simon Frei 26d87ec3bb lib/fs: Don't panic when watching a folder with symlinked root (#4846) 2018-03-28 22:01:25 +01:00
Simon Frei bea6ecaf35 lib/scanner, lib/model: Actually assign version when un-ignoring (fixes #4841) (#4842) 
This fixes a mistake introduced in #4750 and #4776 and is relevant to v0.14.46-rc1
 2018-03-27 16:25:36 -04:00
Simon Frei 69f2c26d50 lib/scanner, lib/model: Actually assign version when un-ignoring (fixes #4841) (#4842) 
This fixes a mistake introduced in #4750 and #4776 and is relevant to v0.14.46-rc1
 2018-03-27 16:24:20 -04:00
Simon Frei a557d62c4a all: Transition to using fs watcher by default (fixes #4552) 2018-03-25 21:05:47 +01:00
Simon Frei da3b38ccce lib/fs: Fix and update error about inotify watch limit (fixes #4833) (#4835) 2018-03-23 12:56:38 +01:00
Simon Frei 81bd428b25 review & forgotten fixes from other PR 2018-03-18 01:10:13 +00:00
Simon Frei ae74ac8329 gui: Tabify edit folder modal 
Copied over from settings. Moves ignore patterns from its own modal into a tab
of the folder edit modal. Advanced settings are in a tab instead of a expandable
section and versioning gets it's own tab.
Also added modal hidden event handler to remove the anchor in the url.
 2018-03-18 01:10:13 +00:00
Simon Frei 5520022766 lig/ignore, lib/logger: Fix race and potential dead-locks when logging (#4821) 2018-03-17 16:49:12 +01:00
Simon Frei 55a7830ff9 lib/fs, lib/model: Make tests caching compatible (fixes #4749) (#4804) 2018-03-13 14:03:10 +01:00
Simon Frei b31bad1c4d lib/model: Remove unused shouldIgnore function (#4805) 2018-03-12 20:16:40 +01:00
Simon Frei 8b4346c3ec lib/scanner, lib/fs: Don't create file infos with abs paths (fixes #4799) (#4800) 2018-03-12 13:18:59 +01:00
Simon Frei 2bdb37d412 cmd/syncthing: More information in help about -logfile option (#4796) 2018-03-12 13:17:12 +01:00
Simon Frei 3949b750f5 gui: In remote need use index and auto-expand if only one folder (fixes #4759) (#4781) 2018-03-01 16:21:35 +01:00
Simon Frei 36251b86f7 lib/model: Mark deleted file as conflicting when un-ignoring (#4776) 
This completes #4750 as a followup to #4765.
 2018-02-25 13:03:55 +01:00
Simon Frei 158859a1e2 lib: Handle metadata changes for send-only folders (fixes #4616, fixes #4627) (#4750) 
Unignored files are marked as conflicting while scanning, which is then resolved
in the subsequent pull. Automatically reconciles needed items on send-only
folders, if they do not actually differ except for internal metadata.
 2018-02-25 09:39:00 +01:00
Simon Frei 5822222c74 lib/model: More precise deletion detection (fixes #2571, fixes #4573) (#4765) 2018-02-25 09:27:54 +01:00
Simon Frei 6802505dda lib/fs: Fix MkdirAll failure due to \\?\ (fixes #4762) (#4763) 2018-02-16 15:19:20 +01:00
Simon Frei 68c1b2dd47 all: Revert simultaneously walk fs and db on scan (fixes #4756) (#4757) 
This reverts commit 6d3f9d5154.
 2018-02-14 08:59:46 +01:00
Simon Frei 4955297bf6 lib/protocol: Invalid files should always lose (#4747) 2018-02-10 19:40:57 +01:00
Simon Frei 6d3f9d5154 all: Simultaneously walk fs and db on scan (fixes #2571, fixes #4573) (#4584) 
When scanner.Walk detects a change, it now returns the new file info as well as the old file info. It also finds deleted and ignored files while scanning.
Also directory deletions are now always committed to db after their children to prevent temporary failure on remote due to non-empty directory.
 2018-02-10 16:56:53 +01:00
Simon Frei 3f4f6d5787 gui: Handle paused folders and fix translation strings for fs watcher (ref #4713) (#4740) 2018-02-07 13:46:27 +01:00
Simon Frei 8a3e584c19 lib/fs: Introduce walkfs debug facility (#4712) 2018-02-05 11:07:56 +01:00
Simon Frei f87f13081b all: Display fs watcher status and retry starting it (ref #4552) (#4713) 2018-02-04 22:46:24 +01:00
Simon Frei c7cf361a96 vendor: Update github.com/zillode/notify (#4734) 2018-02-04 22:37:32 +01:00
Simon Frei 14a5561e43 lib/db: Fix benchmarks 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4708
 2018-01-28 11:26:01 +00:00
Simon Frei a0514bb1a7 gui: Add missing translation string to log viewer 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4714
 2018-01-28 08:40:06 +00:00
Simon Frei 80079e8322 lib/fs: Use correct facility name 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4710
 2018-01-27 12:52:48 +00:00
Simon Frei ae760798e1 gui: Display rescan button when out of sync and remove deprecated folder state 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4704
 2018-01-27 09:10:11 +00:00
Simon Frei 364f61bda6 lib/db: Update global counts on invalidation (fixes #4701) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4702
 2018-01-27 09:09:13 +00:00
Simon Frei 885e3f19bd lib/ignores: Update lines even if patterns didn't change (fixes #4689) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4690
 2018-01-20 07:52:57 +00:00
Simon Frei 93b5180e62 lib/model: Refactor Index/IndexUpdate 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4688
LGTM: calmh, AudriusButkevicius
 2018-01-19 14:33:16 +00:00
Simon Frei fae2ca8458 lib/db: Do not modify underlying array of argument 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4685
 2018-01-18 12:40:43 +00:00
Simon Frei a1761795fe lib/ignore: Only handle lines prefixed with #include specially (fixes #4680) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4684
LGTM: AudriusButkevicius, calmh
 2018-01-17 16:56:53 +00:00
Simon Frei bd63fd73b1 lib/model: Microoptimization of unifySubs and blockDiff 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4671
LGTM: AudriusButkevicius, calmh
 2018-01-14 21:52:41 +00:00
Simon Frei fecb21cdb1 gui: New rest endpoint to get errors when web UI is opened 
Since #4340 pulls aren't happening every 10s anymore and may be delayed up to 1h.
This means that no folder error event reaches the web UI for a long time, thus no
failed items will show up for a long time. Now errors are populated when the
web UI is opened.

GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4650
LGTM: AudriusButkevicius
 2018-01-14 17:01:06 +00:00
Simon Frei f1c73999be gui: Count deleted items for remote out of sync items display (fixes #4668) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4669
LGTM: calmh, AudriusButkevicius
 2018-01-14 12:08:40 +00:00
Simon Frei 341b9691a7 lib/connections, lib/model: Additional connection info in logs (fixes #4499) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4665
 2018-01-12 11:27:55 +00:00
Simon Frei d87287c0d0 gui: Prevent error without completion and nicer wrapping (fixes #4636) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4637
 2018-01-05 14:41:40 +00:00
Simon Frei 841205dbfe lib/model: Check for invalid filenames after ignore patterns 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4607
LGTM: calmh, AudriusButkevicius
 2017-12-25 17:54:34 +00:00
Simon Frei 8fa2b7765a gui, lib/model: Display list of files needed by remote (fixes #4369) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4559
LGTM: AudriusButkevicius, calmh
 2017-12-15 20:01:56 +00:00
Simon Frei cce634f340 lib/model: Improve scan scheduling and dir del during pull (fixes #4475 #4476) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4493
 2017-12-07 08:42:03 +00:00
Simon Frei c005b8dcb0 lib/fs: Prolong test timeout on darwin, hopefully fixing flakyness 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4576
 2017-12-06 22:07:08 +00:00
Simon Frei ce29d3a574 all: Various debug logging improvements 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4529
 2017-11-22 08:05:27 +00:00
Simon Frei 6cf01c1d30 lib/model: Don't update ignore hash when pull fails 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4522
 2017-11-17 12:42:41 +00:00
Simon Frei 4efff736b3 lib/connections: Consistent log levels & polish (fixes #4510) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4511
 2017-11-14 21:49:36 +00:00
Simon Frei fa12a18190 lib/model: Handle type changes when pulling (ref #4505 #4506 #4507) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4509
LGTM: AudriusButkevicius, calmh
 2017-11-13 15:16:27 +00:00
Simon Frei c080f677cb all: Add invalid/ignored files to global list, announce to peers (fixes #623) 
This lets us determine accurate completion status for remote peers when they
have ignored files.

GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4460
 2017-11-11 19:18:17 +00:00
Simon Frei ec4c3bae0d lib/watchaggregator: Don't care about timings during testing on darwin 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4502
 2017-11-10 17:05:31 +00:00
Simon Frei f6ea2a7f8e lib/model: Trigger pulls instead of pulling periodically 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4340
 2017-11-07 06:59:35 +00:00
Simon Frei b999b58049 lib/watchaggregator: Relax test timing requirement for the benefit of macos 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4469
 2017-10-26 21:09:10 +00:00
Simon Frei 2953fe40d1 lib/model: Add initial noop watch cancel func (fixes #4464) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4465
 2017-10-26 13:50:30 +02:00
Simon Frei 4b69d0e093 lib/model: Add initial noop watch cancel func (fixes #4464) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4465
 2017-10-26 11:49:06 +00:00
Simon Frei 7ba9e7c322 lib/db: Filter unchanged files when updating and polish 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4426
 2017-10-24 20:05:29 +00:00
Simon Frei dc42db444b lib/model, lib/config: Refactor folder health/error handling (fixes #4445, fixes #4451) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4455
LGTM: AudriusButkevicius, calmh
 2017-10-24 07:58:55 +00:00
Simon Frei 46becc5338 build: Handle split GOPATH 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4447
 2017-10-21 17:37:06 +00:00
Simon Frei 20fac4bb80 main: Improve logging for initial config loading (ref #4431) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4436
 2017-10-21 09:00:24 +00:00
Simon Frei d84b6bb822 build: Warn when being executed outside of gopath 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4425
 2017-10-20 23:10:55 +00:00
Simon Frei 55b63941b8 cmd/syncthing: Add fswatcher and remove useAPIKey stats 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4438
 2017-10-20 16:25:20 +00:00
Simon Frei e70003737b lib/fs: make watcher tests even more darwin slowness resistant 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4439
 2017-10-20 15:59:18 +00:00
Simon Frei c704ba9ef9 gui: "versioner" -> "versioning" and add missing translations 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4435
 2017-10-20 13:55:22 +00:00
Simon Frei 694a7de59d build: Correct import paths for vet tools 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4420
 2017-10-15 10:39:50 +00:00
Simon Frei e588bb29b9 lib/model: remove unused folderFs member from Model 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4389
 2017-09-21 09:03:36 +00:00
Simon Frei 1088eb12ea lib/model: Fix logging inconsistencies (fixes #4375) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4376
 2017-09-18 11:56:19 +00:00
Simon Frei f7d2c58783 lib/model: Deduplicate folder loops 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4352
LGTM: AudriusButkevicius, calmh
 2017-09-07 06:17:47 +00:00
Simon Frei 9dbc509996 lib/ignore: Consistent behaviour for nil *Matcher 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4310
 2017-09-06 06:39:18 +00:00
Simon Frei c41aaad3bb lib/ignore: Ignore duplicate lines in .stignore 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4350
LGTM: AudriusButkevicius, calmh
 2017-09-04 12:46:19 +00:00
Simon Frei 55e0ac3e24 lib/model: Make puller retrying and logging less aggressive 
Currently all errors during pulling and the first of these errors again on
finishing are logged to info. Besides that the errors logged when finishing
are stored in f.errors. This PR moves all logging during pulling to the debug
channel (they might still be relevant in some obscure debugging case) and
uses the stored errors to log the main error per fail when all pulling
iterations are done and failed.

Additional instead of trying 11 times it now only tries 3 times.

This is the first part of what is discussed here:
https://forum.syncthing.net/t/reduce-verboseness-of-puller/10261

GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4338
 2017-09-02 06:05:55 +00:00
Simon Frei ddf6d64faa lib/model: Create folders via newFolder 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4329
 2017-08-25 19:47:01 +00:00
Simon Frei c7221b035d gui: Round down in devices completion (consistent with folders) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4325
 2017-08-24 04:26:12 +00:00
Simon Frei 0ca0e3e9bd lib/model: GetIgnores: Don't return error for no .stignore file 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4311
 2017-08-22 06:48:25 +00:00
Simon Frei ab8c2fb5c7 lib/model: Fix race in GetIgnores (fixes #4300) 
In addition this function returned an error when .stignore file was not
present, which is perfectly valid. Also removed inconsistent nil check in
ignores.go (only relevant for tests) and adjusted walk.go to do what it says
in comments (check if Matcher is nil) to prevent nil deref in tests.

Originally reported in:
https://forum.syncthing.net/t/reason-for-panic-maybe-too-little-ram/10346

Regression from #3996

GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4301
 2017-08-12 17:10:43 +00:00
Simon Frei 77578e8aac gui: Don't set default path editing existing folders without label (fixes #4297) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4298
LGTM: calmh
 2017-08-10 15:31:25 +00:00
Simon Frei a04b92332f gui, lib/config: Add default path for new folders (fixes #2157) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4192
 2017-07-20 13:16:54 +00:00
Simon Frei b75c9f2bbb lib/ignores: Don't add text from includes to lines (fixes #4249) 
Otherwise all the lines from includes will be shown in the web UI instead of
just the #include ... line. This problem was introduced in #3996.

GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4248
LGTM: calmh
 2017-07-06 11:44:11 +00:00
Simon Frei 8d13e01342 gui: Fix discovered devices list (follow-up to #4186) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4239
 2017-06-29 13:47:42 +00:00
Simon Frei 98cfc204ca gui: Add dropdown menu to choose discovered devices to device modal (fixes #4157) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4186
LGTM: AudriusButkevicius, calmh
 2017-06-16 15:27:09 +00:00
Simon Frei 9c4175715a gui: Reset ignore input field when adding remote share (fixes #4203) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4204
LGTM: AudriusButkevicius, calmh
 2017-06-09 05:41:19 +00:00
Simon Frei 719c313b23 cmd/syncthing, lib/logger: Set debug flags on SetDebug for tests 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4187
 2017-06-02 07:04:06 +00:00
Simon Frei dd6bb6d5fd gui: Reset warnings about nested folder roots (fixes #3433) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4173
 2017-05-23 19:54:56 +00:00
Simon Frei 0b854dff9d lib/ignore: Don't match root (".") 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4122
 2017-05-01 16:58:08 +00:00
Simon Frei 9de6cdddfd script: Ignore units and allow translated strings as translate-values 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4120
 2017-04-29 15:48:00 +00:00
Simon Frei 914b09fd1f lib/model: Create root directory for paused folders (fixes #4094) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4095
 2017-04-23 23:50:56 +00:00
Simon Frei 6b188ebcf3 lib/model: Mark initial scan as finished even if failed and refactor (fixes #4103) 
The mechanism to disallow manual scans before the initial scan completed
(#3996) , had the side effect, that if the initial scan failed, no further
scans are allowed. So this marks the initial scan as finished regardless of
whether it succeeded or not.

There was also redundant code in rofolder and a pointless check for folder
health in scanSubsIfHealthy (happens in internalScanFolderSubdirs as well).
This also moves logging from folder.go to ro/rw-folder.go to include the
information about whether it is send-only or send-receive

GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4104
 2017-04-20 00:20:34 +00:00
Simon Frei 5521759b23 lib/model: TestIgnores: Add ms sleep on all platforms (ref #3986 #3996) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4083
 2017-04-06 09:55:54 +00:00
Simon Frei 25b314f5f1 lib/model, gui: Allow creating and editing ignores of paused folders (fixes #3608) 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3996
LGTM: calmh, AudriusButkevicius
 2017-04-01 09:58:06 +00:00
Simon Frei 1ad547fb65 gui, script: Translate discovery popover and detect it in translate script 
Skip-check: pr-solaris

GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4061
 2017-03-25 11:56:51 +00:00
Simon Frei 88dfd634e5 script, gui: Silence useless warnings in translation script 
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4034
LGTM: AudriusButkevicius
 2017-03-18 00:27:22 +00:00