perso/mcp-maildir
4
0 Fork 0
Code Issues 1 Pull Requests 2 Actions 2 Packages Projects Releases Wiki Activity

fix(indexer): restore module-level embedding/batch constants (cronjobs cassés) #59

Merged
jcabillot merged 1 commits from fix/indexer-missing-constants into main 2026-10-17 17:11:54 -04:00
Conversation 0 Commits 1 Files Changed 3
+35 -1
1 Commits
Author SHA1 Message Date
Sagent 3b575bbf83 fix(indexer): restore module-level embedding/batch constants
PR Checks / hadolint (pull_request) Successful in 12s
Details
Docker Build and Push / test (pull_request) Successful in 2m17s
Details
Docker Build and Push / integration-test (pull_request) Successful in 2m38s
Details
PR Checks / pytest (pull_request) Successful in 2m19s
Details
Docker Build and Push / build (pull_request) Successful in 2m39s
Details
PR Checks / build-test (pull_request) Successful in 3m5s
Details 
The "make indexer importable without env" refactor (e32806a, merged via PR
#52 on 2026-10-09) removed EMBEDDING_MODEL_NAME, BATCH_SIZE and
EMBEDDING_BATCH_SIZE from the module scope while main() kept referencing
them, so every indexer run died before reaching Qdrant:

    File "/app/src/indexer.py", line 264, in main
        print(f"Loading embedding model: {EMBEDDING_MODEL_NAME}...")
    NameError: name 'EMBEDDING_MODEL_NAME' is not defined

CI never caught it because no test executes main(). Both *-indexer cronjobs
have been failing (BackoffLimitExceeded) since 2026-10-16, i.e. the first
run after the image pin moved to v0.0.22-latest.

- restore the three constants with their pre-refactor defaults
- cover them in tests/test_indexer.py and cross-check that the indexer
  embeds with the same model as server.py (vectors must stay comparable)
- add a ruff F821 gate to the unit job so undefined names fail CI

Fixes mcp-maildir-cabilloteu-indexer and mcp-maildir-gmail-indexer.
 2026-10-17 21:04:34 +00:00